Skip to content

refactor: use evmClientFactory pattern from other repositories #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jipperism wants to merge 1 commit into from
Closed

refactor: use evmClientFactory pattern from other repositories #235

Jipperism wants to merge 1 commit into from

Conversation

@Jipperism
Copy link
Contributor

@Jipperism Jipperism commented Jan 31, 2025

  • Refactors creation of evm clients to the same pattern used in indexer and frontend repositories
  • Resolves issues with minting and deleting blueprints on filecoin

@Jipperism
refactor: use evmClientFactory pattern from other repositories
dd7bc5b 
- Refactors creation of evm clients to the same pattern used in indexer and frontend repositories
@github-actions
Copy link

github-actions bot commented Jan 31, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 21.89% (🎯 20%) 913 / 4169
🟢 Statements 21.89% (🎯 20%) 913 / 4169
🔴 Functions 50.63% (🎯 52%) 40 / 79
🟢 Branches 68.66% (🎯 63%) 149 / 217
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/controllers/BlueprintController.ts 0% 0% 0% 0% 1-394
src/controllers/MarketplaceController.ts 0% 0% 0% 0% 1-494
src/lib/safe-signature-verification/SafeSignatureVerifier.ts 2.85% 0% 0% 2.85% 5-46
src/utils/chainFactory.ts 56.66% 100% 0% 56.66% 31-42, 45-46
src/utils/constants.ts 100% 100% 100% 100%
src/utils/evmClient.ts 87.05% 82.35% 88.88% 87.05% 75-87
src/utils/getTokenPriceInUSD.ts 0% 0% 0% 0% 1-213
src/utils/rpcClientFactory.ts 22.22% 100% 20% 22.22% 17-35, 43-56, 60-64, 69-70
src/utils/verifyAuthSignedData.ts 9.09% 100% 0% 9.09% 5-26
src/utils/waitForTxThenMintBlueprint.ts 0% 0% 0% 0% 1-32
Generated in workflow #43 for commit dd7bc5b by the Vitest Coverage Report Action

@Jipperism
Copy link
Contributor Author

Jipperism commented Jan 31, 2025

Closing in favor of #221.

@Jipperism Jipperism closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jipperism